Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a timeout for runner jobs #41

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Add a timeout for runner jobs #41

merged 1 commit into from
Oct 23, 2024

Conversation

lkeegan
Copy link
Member

@lkeegan lkeegan commented Oct 23, 2024

  • Add runner job timeout
    • if a job status has been "running" for too long, it is reset to "queued" to allow another runner to claim it
  • Ignore repeat results
    • if a sample already has a results zip file, ignore a new result
    • this could happen if a job took longer than the timeout but eventually completed
  • add runner job timeout to admin settings
  • resolves add timeout for jobs #32

@lkeegan
Add a timeout for runner jobs
a636a50 
- Add runner job timeout
  - if a job status has been "running" for too long, it is reset to "queued" to allow another runner to claim it
- Ignore repeat results
  - if a sample already has a results zip file, ignore a new result
  - this could happen if a job took longer than the timeout but eventually completed
- add runner job timeout to admin settings
- resolves #32
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 56.25000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 78.18%. Comparing base (afc9d53) to head (a636a50).

Files with missing lines Patch % Lines
backend/src/predicTCR_server/model.py 56.25% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
- Coverage   78.74%   78.18%   -0.56%     
==========================================
  Files           8        8              
  Lines         635      651      +16     
==========================================
+ Hits          500      509       +9     
- Misses        135      142       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkeegan lkeegan merged commit 4fb00da into main Oct 23, 2024
5 checks passed
@lkeegan lkeegan deleted the fix_32_job_timeout branch October 23, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add timeout for jobs
2 participants
@lkeegan @codecov-commenter